New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.10] get_url: Fix checksum binary validation #74674
Conversation
The test
|
needs_info (failing CI) |
@resmo This pullrequest is waiting for your response. Please respond or the pullrequest will be closed. |
rebased |
- name: download src with sha256 checksum url with file scheme | ||
get_url: | ||
url: 'http://localhost:{{ http_port }}/27617.txt' | ||
dest: '{{ remote_tmp_dir }}/27617sha256_with_file_scheme.txt' | ||
checksum: 'sha256:file://{{ files_dir }}/sha256sum.txt' | ||
register: result_sha256_with_file_scheme | ||
|
||
- stat: | ||
path: "{{ remote_tmp_dir }}/27617sha256_with_dot.txt" | ||
register: stat_result_sha256_with_file_scheme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_url
does not have support for file://
in Stable-2.10 which was added via #71205
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added backport via #75052
- name: download 71420.txt with sha256 checksum url with file scheme | ||
get_url: | ||
url: 'http://localhost:{{ http_port }}/71420.txt' | ||
dest: '{{ remote_tmp_dir }}/71420sha256_with_file_scheme.txt' | ||
checksum: 'sha256:file://{{ files_dir }}/sha256sum.txt' | ||
register: result_sha256_with_file_scheme_71420 | ||
|
||
- stat: | ||
path: "{{ remote_tmp_dir }}/71420sha256_with_dot.txt" | ||
register: stat_result_sha256_with_file_scheme_71420 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
This needs another rebase and to see if it passes tests now that #75052 was merged. needs_info |
From the sha512sum man page: ... The default mode is to print a line with checksum, a character indicating type ('*' for binary, ' ' for text), and name for each FILE. (cherry picked from commit 403a5d1)
rebased but zuul is not happy. I don't see why and how to make zuul happy. |
The Zuul check was enabled by mistake and can be ignored. |
SUMMARY
backport of #74502 and #71435 ( /cc @Akasurde )
ISSUE TYPE
COMPONENT NAME
get_url
ADDITIONAL INFORMATION